[ENQUEUE] Precise phpdoc for static analysis #1306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI @makasim,
The
CommandSubscriberInterface::getSubscribedCommand
is currently annotated withstring|array
return type.Static analysis tool allows to provide a more precise return type.
This PR allow PHPStan and Psalm users to have to proper static analysis of the return type when implementing the interface.
I based the array type on the current phpdoc, talking about